[PATCH] When dumping from file system show results in sane order

David Gibson david at gibson.dropbear.id.au
Tue Oct 12 10:55:46 EST 2010


On Tue, Oct 05, 2010 at 02:07:21PM -0500, Matthew McClintock wrote:
> Currently, when we run the following
> 
> $> dtc -I fs -O dts /proc/device-tree
> 
> We get the output in a "reverse order", this patch will reverse that
> output order and should resemble your initial device more closely

Reverse order from what?  Directory entries are unordered for most
intents and purposes - there's no guarantee that readdir() will return
entries in a consistent order, and behaviour in practice will vary
from one filesystem to another.

Your patch doesn't reverse the order - it sorts the items.  If that's
what you actually want, then my general dtdiff and sorting patch will
serve you better, as Grant suggests.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson


More information about the devicetree-discuss mailing list