[PATCH 3/8] of/fdt: Add unflatten_partial_device_tree

Grant Likely grant.likely at secretlab.ca
Wed Nov 17 12:48:18 EST 2010


On Tue, Nov 16, 2010 at 5:44 PM, Stephen Neuendorffer
<stephen.neuendorffer at xilinx.com> wrote:
>
>> >> > @@ -521,12 +539,12 @@ int __init early_init_dt_scan_chosen(unsigned long node, const char *uname,
>> >> >
>> >> >        early_init_dt_check_for_initrd(node);
>> >> >
>> >> > +#ifdef CONFIG_CMDLINE
>> >> >        /* Retreive command line */
>> >> > -       p = of_get_flat_dt_prop(node, "bootargs", &l);
>> >> > +       p = of_get_flat_dt_prop(node, "bootargs", &l, initial_boot_params);
>> >> >        if (p != NULL && l > 0)
>> >> >                strlcpy(cmd_line, p, min((int)l, COMMAND_LINE_SIZE));
>> >> >
>> >> > -#ifdef CONFIG_CMDLINE
>> >>
>> >> Why is this being changed?
>> >
>> > Because it requires a cmd_line global, which all architectures (especially x86) don't seem to have)
>> > Probably if the early stuff get's factored out, then this problem goes away.
>>
>> I'm considering changing this so that cmd_line is set with an
>> arch-specific callback.
>
> I don't think I ever saw a patch for this.  Have you done more than think about this?

Nope!

g.


More information about the devicetree-discuss mailing list