[PATCH 4/7] mmc: sdhci-of: fix build on non-powerpc platforms

Rob Herring robherring2 at gmail.com
Wed Nov 17 09:34:56 EST 2010


On 11/16/2010 03:44 PM, Wolfram Sang wrote:
> On Tue, Nov 16, 2010 at 02:33:52PM -0600, Rob Herring wrote:
>> From: Rob Herring<rob.herring at calxeda.com>
>>
>> Explicitly include err.h, of_address.h and of_irq.h.
>> Make use of machine_is() conditional on PPC.
>>
>> Signed-off-by: Rob Herring<rob.herring at calxeda.com>
>
> Hmm, sins of the past :/ I wonder if we can get away with less #ifdeffery, will
> think about it...
>

I don't want to start a long debate, but is updating a kernel without 
updating the dtb really something to worry about? Isn't a year enough of 
a transition period.

Do these machines have a machine level compatible property that could be 
used instead?

Rob


More information about the devicetree-discuss mailing list