[PATCH] OF device tree: Move of_get_mac_address() to a common source file.

Grant Likely grant.likely at secretlab.ca
Mon Nov 1 16:17:34 EST 2010


On Tue, Oct 26, 2010 at 03:07:13PM -0700, David Daney wrote:
> There are two identical implementations of of_get_mac_address(), one
> each in arch/powerpc/kernel/prom_parse.c and
> arch/microblaze/kernel/prom_parse.c.  Move this function to a new
> common file of_net.{c,h} and adjust all the callers to include the new
> header.

Applied, thanks; but made some changes to protect this code because it
does not work on little endian (it can be fixed in a separate patch)

Also...

> 
> Signed-off-by: David Daney <ddaney at caviumnetworks.com>
> Cc: Michal Simek <monstr at monstr.eu>
> Cc: Grant Likely <grant.likely at secretlab.ca>
> Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> Cc: Wolfram Sang <w.sang at pengutronix.de>
> Cc: Paul Mackerras <paulus at samba.org>
> Cc: "David S. Miller" <davem at davemloft.net>
> Cc: Corey Minyard <cminyard at mvista.com>
> Cc: Pantelis Antoniou <pantelis.antoniou at gmail.com>
> Cc: Vitaly Bordug <vbordug at ru.mvista.com>
> Cc: Anatolij Gustschin <agust at denx.de>
> Cc: John Rigby <jcrigby at gmail.com>
> Cc: Wolfgang Denk <wd at denx.de>
> Cc: Anton Vorontsov <avorontsov at mvista.com>
> Cc: Sandeep Gopalpet <Sandeep.Kumar at freescale.com>
> Cc: Kumar Gala <galak at kernel.crashing.org>
> Cc: Li Yang <leoli at freescale.com>
> Cc: Sergey Matyukevich <geomatsi at gmail.com>
> Cc: Jiri Pirko <jpirko at redhat.com>
> Cc: Eric Dumazet <eric.dumazet at gmail.com>
> Cc: Sean MacLennan <smaclennan at pikatech.com>
> Cc: Sadanand Mutyala <Sadanand.Mutyala at xilinx.com>
> Cc: Andres Salomon <dilinger at queued.net>
> Cc: microblaze-uclinux at itee.uq.edu.au
> Cc: linux-kernel at vger.kernel.org
> Cc: linuxppc-dev at lists.ozlabs.org
> Cc: netdev at vger.kernel.org
> Cc: devicetree-discuss at lists.ozlabs.org

You don't need to believe everything that get_maintainers is telling
you.  When you get a large list like this, don't Cc everyone, but
apply some educated guesses.  You can guess that the PowerPC and
Microblaze maintainers care because it touches their trees, and you
can guess that I care because I'm the dt maintainer. David Miller
isn't a bad guess because of networking.  But 22 people is excessive.

g.


More information about the devicetree-discuss mailing list