[PATCH] of: Fix comparison of "compatible" properties

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Mar 18 17:25:45 EST 2010


On Wed, 2010-03-17 at 23:18 -0700, David Miller wrote:
> > It's not quite right to do partial name match. Entries in a
> compatible
> > list are meant to be matched whole. If a device is compatible with
> both
> > "foo" and "foo1", then the device should have both strings in its
> > "compatible" property.
> > 
> > Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> >       (for patch description)
> > Signed-off-by: Grant Likely <grant.likely at secretlab.ca>
> 
> Acked-by: David S. Miller <davem at davemloft.net>

BTW. While at it... sparc still has it's override here to do partial
match (strncmp iirc). Do you rely on it ? Or do you do that only to be
case insensitive and the "n" is a result of history ?

Cheers,
Ben 



More information about the devicetree-discuss mailing list