[RFC] drivercore: Add of_match_table to the common device drivers

Grant Likely grant.likely at secretlab.ca
Sun Mar 7 18:19:47 EST 2010


On Sun, Mar 7, 2010 at 12:07 AM, Stephen Rothwell <sfr at canb.auug.org.au> wrote:
> Hi Grant,
>
> Just a quick note:
>
> On Sat, 06 Mar 2010 23:47:00 -0700 Grant Likely <grant.likely at secretlab.ca> wrote:
>>
>> diff --git a/drivers/macintosh/macio_asic.c b/drivers/macintosh/macio_asic.c
>> index 67fe13f..a5806ab 100644
>> --- a/drivers/macintosh/macio_asic.c
>> +++ b/drivers/macintosh/macio_asic.c
>> @@ -40,8 +40,7 @@ static struct macio_chip      *macio_on_hold;
>>  static int macio_bus_match(struct device *dev, struct device_driver *drv)
>>  {
>>       struct macio_dev * macio_dev = to_macio_device(dev);
>> -     struct macio_driver * macio_drv = to_macio_driver(drv);
>> -     const struct of_device_id * matches = macio_drv->match_table;
>> +     const struct of_device_id * matches = drv->match_table;
>                                                   ^^^^^^^^^^^
> of_match_table

Heh.  Oops.  I fixed that in my local directory when compile testing,
but neglected to refresh the patch.

Thanks,
g.


More information about the devicetree-discuss mailing list