[PATCH 4/8] of/base.c: export property access/modification functions

Grant Likely grant.likely at secretlab.ca
Sat Jul 17 04:57:02 EST 2010


On Fri, Jul 16, 2010 at 12:38 PM, Stephen Neuendorffer
<stephen.neuendorffer at xilinx.com> wrote:
>
>
>> -----Original Message-----
>> From: glikely at secretlab.ca [mailto:glikely at secretlab.ca] On Behalf Of
> Grant Likely
>> Sent: Friday, July 16, 2010 11:34 AM
>> To: Stephen Neuendorffer
>> Cc: devicetree-discuss at lists.ozlabs.org
>> Subject: Re: [PATCH 4/8] of/base.c: export property
> access/modification functions
>>
>> On Fri, Jul 16, 2010 at 12:13 PM, Stephen Neuendorffer
>> <stephen.neuendorffer at xilinx.com> wrote:
>> > These functions can be usefully used by device drivers.
>>
>> I'd like a little more description of the intended use case.  What are
>> the circumstances where a driver needs to modify the data (this
>> information should be part of the patch description)?
>
> The PCIPR driver code needs to stuff the ranges property using these
> calls...

I'd rather change the translation code to give you an intermediary
value (an offset from a bar), and then use non-OF code to translate
that into a physical address.

g.


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.


More information about the devicetree-discuss mailing list