Fix a filehandle leak

Jon Loeliger jdl at jdl.com
Thu Jul 15 08:31:38 EST 2010


> From: Martin Ettl <ettl.martin at gmx.de>
> 
> During a check of the current git head of the linux kernel with the
> static code analysis tool cppcheck
> (http://sourceforge.net/apps/mediawiki/cppcheck/index.php?title=Main_Page)
> the tool discovered a resource leak in linux-2.6/scripts/dtc/fstree.c.
> 
> Please refer the attached patch, that fixes the issue.
> 
> Fixes https://bugzilla.kernel.org/show_bug.cgi?id=15363
> 
> Signed-off-by: Martin Ettl <ettl.martin at gmx.de>
> Signed-off-by: Michal Marek <mmarek at suse.cz>
> Signed-off-by: David Gibson <david at gibson.dropbear.id.au>
> 
> ---
> 
> Jon, please apply.
> 
>  scripts/dtc/fstree.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/dtc/fstree.c b/scripts/dtc/fstree.c
> index 766b269..8fe1bdf 100644
> --- a/scripts/dtc/fstree.c
> +++ b/scripts/dtc/fstree.c
> @@ -77,6 +77,7 @@ static struct node *read_fstree(const char *dirname)
>  		free(tmpnam);
>  	}
>  
> +	closedir(d);
>  	return tree;
>  }
>  
> -- 
> 1.7.1
> 
> -- 
> David Gibson			| I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _ot
> her_
> 				| _way_ _around_!
> http://www.ozlabs.org/~dgibson

Applied -p 3.

jdl


More information about the devicetree-discuss mailing list