[patch] of: check for IS_ERR()
Dan Carpenter
error27 at gmail.com
Fri Feb 26 20:49:41 EST 2010
get_phy_device() can return an ERR_PTR()
Signed-off-by: Dan Carpenter <error27 at gmail.com>
---
I don't have a cross compile environment set up so I can't even compile
test this. :/ But err.h is included so it should be OK.
diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index 18ecae4..b474833 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -69,7 +69,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
}
phy = get_phy_device(mdio, be32_to_cpup(addr));
- if (!phy) {
+ if (!phy || IS_ERR(phy)) {
dev_err(&mdio->dev, "error probing PHY at address %i\n",
*addr);
continue;
More information about the devicetree-discuss
mailing list