dtc: Allow multiple labels on nodes and properties (v2)

David Gibson david at gibson.dropbear.id.au
Thu Feb 25 08:58:44 EST 2010


On Wed, Feb 24, 2010 at 08:57:05AM -0600, Jon Loeliger wrote:
> > Oops, don't apply that one, it has an uninitialized variable bug.
> > Here's a fixed version.
> > 
> > dtc: Allow multiple labels on nodes and properties
> > 
> > At present, both the grammar and our internal data structures mean
> > that there can be only one label on a node or property.  This is a
> > fairly arbitrary constraint, given that any number of value labels can
> > appear at the same point, and that in C you can have any number of
> > labels on the same statement.
> > 
> > This is pretty much a non-issue now, but it may become important with
> > some of the extensions that Grant and I have in mind.  It's not that
> > hard to change, so this patch does so, allowing an arbitrary number of
> > labels on any given node or property.  As usual a testcase is added
> > too.
> > 
> > Signed-off-by: David Gibson <david at gibson.dropbear.id.au>
> > 
> > Index: dtc/tests/multilabel.dts
> > ===================================================================
> > --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> > +++ dtc/tests/multilabel.dts	2010-02-24 17:57:12.736958851 +1100
> > @@ -0,0 +1,38 @@
> 
> 
> So, I applied this.  But I had to make an extra amend step to
> fix three things after applying it:
> 
>     - Remove the meta-comment, (placed after triple dash line)
>     - Remove the extraneous "(v2)", (placed in Subject brackets)
>     - Remove the duplicate Subject: line, (not repeated in body)

Good point, sorry.  I'll keep that in mind in future.
-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson


More information about the devicetree-discuss mailing list