[PATCH] of: added documentation for spi chipselects

Ernst Schwab eschwab at online.de
Wed Feb 17 23:22:33 EST 2010


Wolfram Sang <w.sang at pengutronix.de> wrote:

> Minor: I'd prefer spaces around the '='.
Done.

> I'd drop the comments. GPIO controllers may have private xlate-functions, so
> '1' could theoretically mean something else than "low-active" (although in
> practice it hopefully won't).

I dropped the polarity stuff. The "reg =" comment seems important
to me, I had to find this out by grep'ing and looking at the 
SPI master sourcecode. 
Patch V2 will be reposted.

Regards
Ernst


More information about the devicetree-discuss mailing list