[RFC PATCH 12/14] ARM: vexpress: add board support for DT probing

[Grant Likely]

On Wed, Aug 18, 2010 at 12:59 PM, Lorenzo Pieralisi
<lorenzo.pieralisi at arm.com> wrote:
> Discussion is under way to decide if a set of machine ids is allocated
> to ARM platforms based on device tree initialization.
> Init code for a given platform should be split in a static init version
> and a device tree init version. The Versatile Express ARM board requires
> the initialization of motherboard and daughterboard in separate steps,
> so the split between static init and DT init is doubled in terms of
> files. Common code should be factored out in common C files to avoid code
> duplication.
>
> This patch refactors the Versatile Express init code in order
> to split it in DT and non-DT versions, compiled in accordingly depending
> on kernel configuration options. Clock look-up for the DT version is
> still work in progress waiting for a definitive clock binding spec so
> device names are not really DT compliant at the moment in the dts.
>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi at arm.com>

Hi Lorenzo,

This ends up looking like quite an imposing patch for something that
should be relatively simple.  At the very least, moving the common
functions should be performed in a separate patch so that the -dt
changes can be reviewed independently of the code reorganization.
I'll need to dig into the detail of this one a bit later when I've got
some time.

Cheers,
g.

> ---
>  arch/arm/mach-vexpress/core.h                  |   15 ++-
>  arch/arm/mach-vexpress/ct-ca9x4-base.c         |  108 +++++++++++++
>  arch/arm/mach-vexpress/ct-ca9x4-of.c           |  192 +++++++++++++++++++++++
>  arch/arm/mach-vexpress/ct-ca9x4.c              |   93 -----------
>  arch/arm/mach-vexpress/include/mach/ct-ca9x4.h |    2 +
>  arch/arm/mach-vexpress/v2m-base.c              |  197 ++++++++++++++++++++++++
>  arch/arm/mach-vexpress/v2m-of.c                |   94 +++++++++++
>  arch/arm/mach-vexpress/v2m.c                   |  178 +---------------------
>  8 files changed, 610 insertions(+), 269 deletions(-)
>  create mode 100644 arch/arm/mach-vexpress/ct-ca9x4-base.c
>  create mode 100644 arch/arm/mach-vexpress/ct-ca9x4-of.c
>  create mode 100644 arch/arm/mach-vexpress/v2m-base.c
>  create mode 100644 arch/arm/mach-vexpress/v2m-of.c
>