[RFC PATCH 2/5] Merge dynamic OF code to of_dynamic.c
Nathan Fontenot
nfont at austin.ibm.com
Fri Nov 6 03:59:22 EST 2009
Grant Likely wrote:
> Hi Nathan,
>
> Thanks for the patches. Comments below.
>
> On Wed, Nov 4, 2009 at 3:16 PM, Nathan Fontenot <nfont at austin.ibm.com> wrote:
>> Creation of the OF dynamic device tree update code in drivers/of. This
>> merges the common device tree updating routines to add/remove nodes and
>> properties from powerpc and microblaze. All of the new code is conditional
>> based on a new OF_DYNAMIC config option.
>
> Rather than one patch to create all the moved functions, and then
> subsequent patches to remove the duplicates from each arch, I've been
> using the pattern of one patch for each function or couple of
> functions to both remove from the old files and add to the new home.
> Would you be able to do the same for your patches here? The merging
> is complicated enough without having to track changes to a function
> between separate commits. Moving one function at a time will also
> make bisecting more friendly.
>
Shouldn't be a problem.
> Also, have you checked what impact these changes have on SPARC?
>
I took a look at sparc code, but will do again as I redo the patches to
make there are no impacts.
>> --- linux-next.orig/drivers/of/Makefile 2009-11-03 11:18:08.000000000 -0600
>> +++ linux-next/drivers/of/Makefile 2009-11-03 13:42:35.000000000 -0600
>> @@ -1,6 +1,7 @@
>> obj-y = base.o
>> -obj-$(CONFIG_OF_DEVICE) += device.o platform.o
>> -obj-$(CONFIG_OF_GPIO) += gpio.o
>> -obj-$(CONFIG_OF_I2C) += of_i2c.o
>> -obj-$(CONFIG_OF_SPI) += of_spi.o
>> -obj-$(CONFIG_OF_MDIO) += of_mdio.o
>> +obj-$(CONFIG_OF_DEVICE) += device.o platform.o
>> +obj-$(CONFIG_OF_GPIO) += gpio.o
>> +obj-$(CONFIG_OF_I2C) += of_i2c.o
>> +obj-$(CONFIG_OF_SPI) += of_spi.o
>> +obj-$(CONFIG_OF_MDIO) += of_mdio.o
>> +obj-$(CONFIG_OF_DYNAMIC) += of_dynamic.o
>
> Unrelated whitespace churn makes it hard to see what actually changed.
>
ok.
-Nathan Fontenot
More information about the devicetree-discuss
mailing list