[PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking
Wolfgang Grandegger
wg at grandegger.com
Wed Apr 1 18:40:13 EST 2009
David Gibson wrote:
> On Tue, Mar 31, 2009 at 02:43:39PM +0200, Wolfgang Grandegger wrote:
>> The I2c node property "fsl,preserve-clocking" allows to overtake the
>> clock settings from the boot loader and avoids the hard-coded setting.
>
> Hrm. This is dubious. The device tree should generally describe
> hardware, not OS/driver behaviour which is what this appears to be
> doing. There are exceptions, but you need to justify them.
I think the purpose of this property is clear. How would you provide
that functionality instead? I suggested that a "clock-frequency = <0>"
property should do the trick but Grant preferred to be more explicit.
Wolfgang.
More information about the devicetree-discuss
mailing list