[PATCH 9/9 V3] Test constant expressions in cell contexts.

David Gibson david at gibson.dropbear.id.au
Tue Sep 30 16:04:18 EST 2008


On Fri, Sep 26, 2008 at 03:25:48PM -0500, Jon Loeliger wrote:
> From: Jon Loeliger <jdl at freescale.com>
> 
> This code is derived from code posted by David Gibson.

[snip]
> +		for (i = 0; i < ARRAY_SIZE(expr_table); i++)
> +			if (fdt32_to_cpu(res[i]) != expr_table[i].result)

Hrm.. when you fixed the endian bug here (I found it myself the other
day), you might have thought to fix it...


> +				FAIL("Incorrect result for expression \"%s\","
> +				     " 0x%x instead of 0x%x\n",
> +				     expr_table[i].expr, res[i],
                                                         ^^^^^^

...here, too.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson



More information about the devicetree-discuss mailing list