[PATCH] Fix an overflow case in fdt_offset_ptr() detected by GCC 4.3.

David Gibson david at gibson.dropbear.id.au
Tue Sep 30 12:39:34 EST 2008


On Mon, Sep 29, 2008 at 08:51:02PM -0500, Jon Loeliger wrote:
> > On Mon, Sep 29, 2008 at 04:13:27PM -0500, Jon Loeliger wrote:
> > > > 
> > 
> > Uh.. Jon.. did you see my reply to this.  I'm not at all convinced
> > this patches a real problem.  I suspect it's just replacing a problem
> > that gcc could detect with a similar one that gcc can't (and for which
> > we already had a test to deal with, anyway).
> 
> I saw your reply, and you are welcome to read up
> on the fist fight over in GCC land too.
> 
> In the meantime, it fixes a real problem that we
> have at Freescale.

Ok.. and can you explain this real problem?

If this is just to work around a silly gcc warning that appears in
some circumstances and not others, that's fine, but the commit message
should say so.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson



More information about the devicetree-discuss mailing list