[2/5] dtc: Use flex's YY_USER_ACTION feature to avoid code duplication

David Gibson david at gibson.dropbear.id.au
Fri Oct 3 11:05:31 EST 2008


On Thu, Oct 02, 2008 at 11:25:27AM -0500, Jon Loeliger wrote:
> On Fri, 2008-10-03 at 00:05 +1000, David Gibson wrote:
> > Current, every lexer rule starts with some boiler plate to update the
> > yylloc value for use by the parser.  One of the rules, even mistakenly
> > has a redundant allocation to one of the members.
> > 
> > This patch uses the flex YY_USER_ACTION macro hook, which is executed
> > before every rule to avoid this duplication.
> > 
> > Signed-off-by: David Gibson <david at gibson.dropbear.id.au>
> > 
> > ---
> 
> This, and the xstrdup() change are both excellent suggestions.

Ok, so lets apply them, clearing a bit more muck out of the way to
focus on the new language stuff.

But does this imply you don't like the rest of the series?

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson



More information about the devicetree-discuss mailing list