[ccan] make check fails in coroutine module

[David Gibson]

On Sun, Mar 17, 2019 at 03:39:44PM -0700, Ian Zimmerman wrote:
> cc -g3 -ggdb -Wall -Wstrict-prototypes -Wold-style-definition -Wundef -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wwrite-strings -DCCAN_STR_DEBUG=1 -I.  -MMD -MP -MFccan/coroutine/coroutine.o.d -MTccan/coroutine/coroutine.o -c ccan/coroutine/coroutine.c -o ccan/coroutine/coroutine.o
> tools/ccanlint/ccanlint -s --deps-fail-ignore   ccan/coroutine/ && touch ccan/coroutine/.ok
> coroutine: Module's run and api tests pass (tests_pass): FAIL (+0/3)
> /home/itz/git/ccan/ccan/coroutine/test/api-2.c:1..10
> ok 1 - coroutine_stack_check(stack1, NULL) == stack1
> ok 2 - coroutine_stack_size(stack1) == bufsz - COROUTINE_STK_OVERHEAD
> ok 3 - coroutine_stack_check(stack2, NULL) == stack2
> ok 4 - coroutine_stack_size(stack2) == bufsz - COROUTINE_STK_OVERHEAD
> sh: line 1: 24908 Segmentation fault      (core dumped) valgrind -q --leak-check=full --log-fd=3 /tmp/ccanlint-24709.1804289383/api-2 3> /tmp/ccanlint-24709.1804289383/api-2.valgrind-log
> 
> ... more (use -vv to see them all)
> coroutine: Total score: 35/43 FAIL!
> make: *** [Makefile:78: ccan/coroutine/.ok] Error 1
> 
> Perhaps it is relevant that the configurator check causing the segfault
> - as discussed in the other thread - is HAVE_POINTER_SAFE_MAKECONTEXT
> which, I believe, is only used by coroutine module.
> 
> Platform: x86_64, Fedora 28, gcc 8.3.1, glibc 2.27.  I didn't set any
> special build flags or anything.

Urgh, yeah, it's broken.  Finding time to debug and fix it is proving
difficult.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/ccan/attachments/20190326/c84ce928/attachment.sig>