[ccan] [PATCH v2 07/13] configurator: Fix compiler warning with compare

Kevin Locke kevin at kevinlocke.name
Fri Sep 23 13:33:10 AEST 2016


Visual Studio prints warning C4706 "assignment within conditional
expression" when there is an assignment without a comparison in a
conditional expression.  Therefore, to silence the warning, add an
explicit comparison.

Signed-off-by: Kevin Locke <kevin at kevinlocke.name>
Reviewed-by: David Gibson <david at gibson.dropbear.id.au>
---
 tools/configurator/configurator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/configurator/configurator.c b/tools/configurator/configurator.c
index 51d7ac8..acf6cc0 100644
--- a/tools/configurator/configurator.c
+++ b/tools/configurator/configurator.c
@@ -572,7 +572,7 @@ static bool run_test(const char *cmd, struct test *test)
 		char *dep;
 
 		/* Space-separated dependencies, could be ! for inverse. */
-		while ((len = strcspn(deps, " "))) {
+		while ((len = strcspn(deps, " ")) != 0) {
 			bool positive = true;
 			if (deps[len]) {
 				dep = strdup(deps);
-- 
2.9.3



More information about the ccan mailing list