[ccan] [PATCH v3 0/7] configurator: Support for Windows and MSVC

[Kevin Locke]

On Sat, 2016-10-01 at 01:08 +1000, David Gibson wrote:
> On Wed, Sep 28, 2016 at 06:44:41PM -0600, Kevin Locke wrote:
>> Here is the third revision of the patch series which adds support for
>> building configurator with Microsoft Visual C++ and running it on
>> Windows.
>> 
>> Significant changes from v2:
>> * Removing the unnecessary EINTR and short read/write handling code.
>> * Switching from the musl libc err.h implementation to the CCAN err
>>   module one in hopes of reducing maintenance burden and code
>>   proliferation.
>> * Additional documentation comments for AppVeyor.
> 
> I've merged these to master.

Thanks!  That's great!

> Judging by the FIXMEs in appveyor.yml there's still a lot of things
> broken, but it's a start.

Very true.  At the moment it only tests configurator, although it
generates and ignores compile errors for ccan_depends due to
"-include test-depends".  Fixing that will require the dgraph/tlist
changes previously discussed[1] and possibly other major changes I
haven't discovered yet.  So it's on hold for now unless anyone is
really eager to push it forward.

> I set myself up an appveyor account and tweaked your comment to point
> at that instead of the hypothetical one Rusty may or may not set up at
> some point.
> 
> I've actually set up two appveyor projects: one which tracks my github
> ccan repository at:
>     https://ci.appveyor.com/project/dgibson/ccan-c44x3
> 
> And another which tracks the upstream master git for ccan at:
>     https://ci.appveyor.com/project/dgibson/ccan
> 
> Bizarrely, the github one is working great, whereas the direct git one
> is giving errors, even though they're showing as building exactly the
> same commit :/.  It kind of looks like the master one is ignoring the
> appveyor.yml for no apparent reason - it seems to be looking for a
> vcproj file instead of using the build scripts you've supplied.

Looks great!  Thanks for taking the time to set that up!

I it looks like this is a result of AppVeyor not using appveyor.yml
for custom Git repositories.[2]  I've added a comment to the issue in
their GitHub issue tracker to see what can be done.  If they don't
move on it, it would be possible to copy the settings from
appveyor.yml into the project settings web interface, with the caveat
that they wouldn't be updated from the repo in the future.  I'll
follow up when/if I hear back from the AppVeyor folks.

Thanks again for all of your effort on this,
Kevin

1.  https://lists.ozlabs.org/pipermail/ccan/2016-September/001248.html
2.  https://github.com/appveyor/ci/issues/545