[ccan] Test failure in rszshm

[David Gibson]

On Mon, Feb 01, 2016 at 04:15:06PM +0000, Dan Good wrote:
> That particular test is asking mmap to create a mapping of size UINT64_MAX
> and expecting it to fail with ENOMEM.  Are you getting a different
> errno?

Yes, it seems I'm getting EINVAL.  But the EINVAL is coming from the
mmap() call, *not* the initial tests in rszshm_mk() which explicitly
set EINVAL.

But what's *really* weird, is I get it when I run ccanlint directly,
but not when it then re-runs the tests under gdb.  And as far as I can
tell mmap() is getting exactly the same arguments :/.

> 
> On Mon, Feb 1, 2016 at 6:07 AM David Gibson <david at gibson.dropbear.id.au>
> wrote:
> 
> > So, for me at least, ccanlint is failing on the rszshm module (and
> > therefore make check is failing as well).  I only see one commit for
> > that module, so I think it must have always been broken.
> >
> > not ok 13 - rszshm_mk(&t, 4096, NULL, scan) == NULL && errno == ENOMEM
> > #     Failed test (/home/dwg/src/ccan/ccan/rszshm/test/run.c:main() at
> > line 96)
> >
> >

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/ccan/attachments/20160203/8893daa8/attachment.sig>