[ccan] [PATCH 1/7] aga: Abstract Graph Algorithms

Rusty Russell rusty at rustcorp.com.au
Fri Jul 10 10:37:25 AEST 2015


David Gibson <david at gibson.dropbear.id.au> writes:
> This module implements some standard graph algoriths.  Rather than
> expecting a specific concrete representation of the graph, it uses
> callbacks, so that the calling code can compute the graph edges on the fly.
> The graph nodes can also be constructed as they're discovered, although
> some information about them does then need to be retained for the life of
> the algorithm.

I've taken to just putting "aga: new module" or "aga: <summary line>"
in the commit message.

My theory is that everything else should be in _info anyway...

> --- /dev/null
> +++ b/ccan/aga/_info
> @@ -0,0 +1,33 @@
> +#include "config.h"
> +#include <stdio.h>
> +#include <string.h>
> +
> +/**
> + * aga - Abstract Graph Algorithms
> + *
> + * This modules contains several standard graph algorithms,
> + * implemented so that they don't rely on a specific represnetation of

Typo: s/represnetation/representation/

> +int aga_error(struct aga_graph *g)

const?

Rest looks good...

Cheers,
Rusty.


More information about the ccan mailing list