[ccan] [PATCH 4/5] list: add list_for_each_rev_off macro

Eric Wong normalperson at yhbt.net
Sat Oct 25 09:02:31 AEDT 2014


And re-implement list_for_each_rev in terms of list_for_each_rev_off
to avoid duplicating iteration logic.

Signed-off-by: Eric Wong <normalperson at yhbt.net>
---
 ccan/list/list.h | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/ccan/list/list.h b/ccan/list/list.h
index 90989c5..aaf135d 100644
--- a/ccan/list/list.h
+++ b/ccan/list/list.h
@@ -522,9 +522,7 @@ static inline const void *list_tail_(const struct list_head *h, size_t off)
  *		printf("Name: %s\n", child->name);
  */
 #define list_for_each_rev(h, i, member)					\
-	for (i = container_of_var(list_debug(h,	LIST_LOC)->n.prev, i, member); \
-	     &i->member != &(h)->n;					\
-	     i = container_of_var(i->member.prev, i, member))
+	list_for_each_rev_off(h, i, list_off_var_(i, member))
 
 /**
  * list_for_each_safe - iterate through a list, maybe during deletion
@@ -704,6 +702,17 @@ static inline void list_prepend_list_(struct list_head *to,
 	list_for_each_off_dir_((h),(i),(off),next)
 
 /**
+ * list_for_each_rev_off - iterate through a list of memory regions backwards
+ * @h: the list_head
+ * @i: the pointer to a memory region wich contains list node data.
+ * @off: offset(relative to @i) at which list node data resides.
+ *
+ * See list_for_each_off for details
+ */
+#define list_for_each_rev_off(h, i, off)                                    \
+	list_for_each_off_dir_((h),(i),(off),prev)
+
+/**
  * list_for_each_safe_off - iterate through a list of memory regions, maybe
  * during deletion
  * @h: the list_head
-- 
EW



More information about the ccan mailing list