[ccan] [PATCH 6/6] cpuid: Minor improvements

Ahmed Samy f.fallen45 at gmail.com
Thu Oct 10 06:01:39 EST 2013


On Fri, Oct 4, 2013 at 4:08 PM, Emilio G. Cota <cota at braap.org> wrote:

> On Fri, Oct 04, 2013 at 02:47:52 +0200, Ahmed Samy wrote:
> > Oops, my bad.
> > This one should fix it.
>
> Applying this patch on top of the previous one fixed it
> for me.
>
>   Tested-by: Emilio G. Cota <cota at braap.org>
>
> I have noticed that there are unrelated changes in these patches.
> Before pushing the changes, you should try to break unrelated changes
> into separate, meaningful commits -- this not only helps reviewers to
> evaluate your work, it also helps when problems arise and reverts need
> to be applied.
>
> Thanks,
>
>                 Emilio
>
Yeah, I was just trying to get the problem fixed because I had no test
environment :P

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/ccan/attachments/20131009/e44c2b67/attachment.html>


More information about the ccan mailing list