[ccan] [PATCH] tap: fix pthread uses

[Rusty Russell]

On Sun,  3 Jul 2011 20:36:48 +0300, "Kirill A. Shutemov" <kirill at shutemov.name> wrote:
> From: "Kirill A. Shutemov" <kirill at shutemov.name>
> 
> tap expects that HAVE_LIBPTHREAD will be defined, but configurator
> doesn't provide it:
> 
> ccan/tap/tap.c:49:5: warning: "HAVE_LIBPTHREAD" is not defined [-Wundef]
> 
> Lets check for <pthread.h> in configurator and provide HAVE_PTHREAD_H
> based on the results.
> 
> Signed-off-by: Kirill A. Shutemov <kirill at shutemov.name>

Hmm, this predates me taking over maintenance of tap.

I'm not entirely convinced that having multiple threads use tap at the
same time makes sense, nor sure that dragging in pthreads for every tap
user is desirable.

I'm tempted to change it to WANT_PTHREAD.  Do you actually need it?

Thanks,
Rusty.