[ccan] [PATCH 2/2] opt: Silence unsed param warning triggered by -Wextra

Joel Stanley joel at jms.id.au
Mon Feb 7 15:06:16 EST 2011


The type checking function does not use its parameter:

    ccan/opt/opt.h: In function ‘_check_is_entry’:
        ccan/opt/opt.h:328:53: warning: unused parameter ‘e’

Annotate the function using UNUSED from compiler.h.  This commit also
adds compiler.h as a dependency for opt.
---
 ccan/opt/_info |    1 +
 ccan/opt/opt.h |    3 ++-
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/ccan/opt/_info b/ccan/opt/_info
index e818b2e..a051832 100644
--- a/ccan/opt/_info
+++ b/ccan/opt/_info
@@ -59,6 +59,7 @@ int main(int argc, char *argv[])
 
 	if (strcmp(argv[1], "depends") == 0) {
 		printf("ccan/typesafe_cb\n");
+		printf("ccan/compiler\n");
 		return 0;
 	}
 
diff --git a/ccan/opt/opt.h b/ccan/opt/opt.h
index a1adc41..0748fe6 100644
--- a/ccan/opt/opt.h
+++ b/ccan/opt/opt.h
@@ -1,5 +1,6 @@
 #ifndef CCAN_OPT_H
 #define CCAN_OPT_H
+#include <ccan/compiler/compiler.h>
 #include <ccan/typesafe_cb/typesafe_cb.h>
 #include <stdbool.h>
 
@@ -325,6 +326,6 @@ void _opt_register(const char *names, enum opt_type type,
 		   void *arg, const char *desc);
 
 /* We use this to get typechecking for OPT_SUBTABLE */
-static inline int _check_is_entry(struct opt_table *e) { return 0; }
+static inline int _check_is_entry(struct opt_table *e UNUSED) { return 0; }
 
 #endif /* CCAN_OPT_H */
-- 
1.7.2.3



More information about the ccan mailing list