[Cbe-oss-dev] [PATCH v2] block: Fix ps3vram sparse warnings

Geoff Levand geoff at infradead.org
Sat Mar 23 05:12:43 EST 2013


Hi Geert,

On Fri, 2013-03-22 at 07:18 +0100, Geert Uytterhoeven wrote:
> On Fri, Mar 22, 2013 at 1:14 AM, Geoff Levand <geoff at infradead.org> wrote:
> > On Thu, 2013-03-21 at 17:19 -0400, Jim Paris wrote:
> >> It's been a while since I've looked at any of this, and I'm unable to
> >> test on the PS3 at the moment, but shouldn't this be ioread32be() and
> >> iowrite32be() instead of readl() and writel() throughout here?
> >
> > Thanks for checking.  It even boots now...
> 
> Do you mean it didn't boot before? If yes, when did it become broken?

When I used readl() and writel() it would hang when the vram driver was
initialized.  I didn't test it until after I sent out that first patch.
I guess readl_be() and writel_be() would work.

-Geoff




More information about the cbe-oss-dev mailing list