[Cbe-oss-dev] [PATCH 1/2 v2] usb: Remove ehci_reset call from ehci_run

[Alan Stern]

On Wed, 23 Nov 2011, Geoff Levand wrote:

> Remove the ehci_reset() call done in the ehci_run() routine of the
> USB EHCI host controller driver and add an ehci_reset() call to the
> probe routine of all EHCI platform drivers that do not already call
> ehci_reset().
> 
> The call to ehci_reset() from ehci_run() was problematic for several
> platform drivers, and unnecessary for others.  This change moves the
> decision to call ehci_reset() at driver startup to the platform
> driver code.
> 
> Signed-off-by: Geoff Levand <geoff at infradead.org>
> ---
> 
> Hi Alan,
> 
> I went through and reduced the patch down to what I think is the minimum needed.  More review/checks are appreciated.

Let's see...  You missed ehci-octeon.c.  Also, the change to 
ehci-au1xxx.c is correct but in all the other platform drivers, you 
added the call to ehci_reset() in the wrong place.  The call must be 
made either in the probe routine _before_ the call to usb_add_hcd() or 
else in the reset routine (which many of the drivers call *_setup).

But you're definitely heading in the right direction.  :-)

Alan Stern