[Cbe-oss-dev] [PATCH] arch/powerpc/platforms/cell/spider-pci.c: fix wrong spider base for QS20

[Arnd Bergmann]

On Friday 21 October 2011, Dominik Klein wrote:
> Commit 7cfb62a2e820b6032c08835dbd996d8518af14a3 restructured the PCI 
> workarounds for Spider. One line of code which works around an error in the 
> QS20 device tree apparently went missing in the process. Without it, kernels 
> will crash on QS20 if there are InfiniBand cards installed in the PCIe slots.
> 
> This patch re-introduces this workaround and guards it by a model check so
> that Celleb won't be affected.
> 
> Signed-off-by: Dominik Klein <dominik.klein at gmx.com>

Hi Dominik,

The patch seems technically correct in terms of restoring the previous
state, but it does look extremely hacky. Basically we take a resource,
subtract one value and add another one. What are the actual values
of 'r.start' (before the &=) and 'offset' here? Any chance that we
should simply fix the 'offset' value in the cell_setup_phb
function to get to the same result?

	Arnd