[Cbe-oss-dev] [PATCH 1/2] arch/powerpc/platforms/cell/iommu.c: add missing of_node_put

Arnd Bergmann arnd at arndb.de
Mon Aug 29 21:26:49 EST 2011


On Sunday 21 August 2011, Julia Lawall wrote:
> From: Julia Lawall <julia at diku.dk>
> 
> np is initialized to the result of calling a function that calls
> of_node_get, so of_node_put should be called before the pointer is dropped.
> 
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression e,e1,e2;
> @@
> 
> * e = \(of_find_node_by_type\|of_find_node_by_name\)(...)
>   ... when != of_node_put(e)
>       when != true e == NULL
>       when != e2 = e
>   e = e1
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia at diku.dk>
> 
Acked-by: Arnd Bergmann <arnd at arndb.de>


More information about the cbe-oss-dev mailing list