[Cbe-oss-dev] [PATCH] PS3: Fixed Coding Style Issues in ps3av.c

Geert Uytterhoeven geert at linux-m68k.org
Sun Aug 14 00:31:43 EST 2011


On Fri, Aug 12, 2011 at 10:52, Venkatram Tummala <venkatram867 at gmail.com> wrote:
> diff --git a/drivers/ps3/ps3av.c b/drivers/ps3/ps3av.c
> index a409fa0..e6d1a3d 100644
> --- a/drivers/ps3/ps3av.c
> +++ b/drivers/ps3/ps3av.c
> @@ -26,7 +26,7 @@
>  #include <linux/fb.h>
>  #include <linux/slab.h>
>
> -#include <asm/firmware.h>
> +#include <linux/firmware.h>

IIRC, arch/powerpc/include/asm/firmware.h is unrelated to linux/firmware.h.
Does it actually compile when not including asm/firmware.h explicitly?

The rest looks OK to me.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds


More information about the cbe-oss-dev mailing list