[Cbe-oss-dev] [PATCH 06/15] ps3flash: Fix region align checks

Andre Heider a.heider at gmail.com
Tue Aug 2 06:56:31 EST 2011


On Mon, Aug 1, 2011 at 10:29 PM, Geert Uytterhoeven
<geert at linux-m68k.org> wrote:
> On Mon, Aug 1, 2011 at 22:02, Andre Heider <a.heider at gmail.com> wrote:
>> The region fields used by the align checks are set in
>> ps3stor_setup(), so move those after that call.
>
> Are you sure?
> Aren't they set in
> arch/powerpc/platforms/ps3/device-init.c:ps3_setup_storage_dev()?

Hm right, unfortunate commit message... :)
dev->region_idx is set in ps3stor_probe_access(), which is called from
ps3stor_setup().
So the code always checked the first region, where it should check the
one beeing used.

Will fix the commit message.

Thanks


More information about the cbe-oss-dev mailing list