[Cbe-oss-dev] [PATCH] block: Turn bvec_k{un, }map_irq() into static inline functions

Jens Axboe jaxboe at fusionio.com
Mon Oct 18 05:06:53 EST 2010


On 2010-10-17 13:38, Geert Uytterhoeven wrote:
> Convert bvec_k{un,}map_irq() from macros to static inline functions if
> !CONFIG_HIGHMEM, so we can easier detect mistakes like the one fixed in
> 93055c31045a2d5599ec613a0c6cdcefc481a460 ("ps3disk: passing wrong variable to
> bvec_kunmap_irq()")

Does this cause any warnings on the existing kernel? It's the same issue
we have with the kunmap_atomic() API, and they are generally used to map
structures etc as well. So char * isn't necessarily always a good
choice, and hence the "fix" there is to just check whether a page struct
is being passed in or not.

OK, so did a quick grep, and there's just the two users of it. So pretty
straight forward, I'll add your patch. Thanks!

-- 
Jens Axboe



More information about the cbe-oss-dev mailing list