[Cbe-oss-dev] [PATCH] powerpc/cell: replace strncpy by strlcpy

[Ken Kawakami]

Arnd-san, Roel-san,

It works fine. Thanks.

---
Regards,
Ken Kawakami

> Replace strncpy() and explicit null-termination by strlcpy()
> 
> Signed-off-by: Roel Kluin <roel.kluin at gmail.com>
> ---
> Arnd-san, Ken-san,
> 
> Thanks for reviewing,
> 
> > We prefer to take the patch which is replacing the two lines with one.
> 
> Doozo.
> 
> diff --git a/arch/powerpc/platforms/cell/celleb_setup.c b/arch/powerpc/platforms/cell/celleb_setup.c
> index 07c234f..e538455 100644
> --- a/arch/powerpc/platforms/cell/celleb_setup.c
> +++ b/arch/powerpc/platforms/cell/celleb_setup.c
> @@ -80,8 +80,7 @@ static void celleb_show_cpuinfo(struct seq_file *m)
>  
>  static int __init celleb_machine_type_hack(char *ptr)
>  {
> -	strncpy(celleb_machine_type, ptr, sizeof(celleb_machine_type));
> -	celleb_machine_type[sizeof(celleb_machine_type)-1] = 0;
> +	strlcpy(celleb_machine_type, ptr, sizeof(celleb_machine_type));
>  	return 0;
>  }
>  
>