[Cbe-oss-dev] [patch 4/8 v2] petitboot: Makefile cleanups

[Jeremy Kerr]

Hi Geoff,

> +AM_CONDITIONAL([COND_WITH_LIBTWIN], [test "x$with_twin" = "xyes"])

We're not using automake. Just a simple conditional add to the list of 
UIs will be fine for this.

> +# headers
> +discover_all_headers = $(wildcard $(top_srcdir)/discover/*.h)
> +lib_headers = $(wildcard $(top_srcdir)/lib/*/*.h)
> +ui_all_headers = $(wildcard $(top_srcdir)/ui/*/*.h)

Nope. We should be doing this properly with -MD.

> -	for f in $$(git-ls-files); do \
> +	for f in $$(git --git-dir=$(top_srcdir)/.git ls-files); do \

Why this change? Is this so we can run make dist outside the source 
tree?

Cheers,

Jeremy