On Fri, Sep 05, 2008 at 07:21:48AM +0800, Jeremy Kerr wrote: > Yep, was thinking about doing this rework; I'll leave that to a separate > patch though, so that the actual fix is as small as possible. Ok. If you do this you can also change __spu_deactivate to return void, as the return value is never checked.