[Cbe-oss-dev] [PATCH 4/10 v3] MARS: task barrier fix notify

Kazunori Asayama asayama at sm.sony.co.jp
Wed Sep 3 13:42:17 EST 2008


Yuji Mano wrote:
> This fixes a bug in task barrier's notify function so it only sends a signal to
> workload id's that are in the wait list.
> 
> This also fixes a bug where the barrier count was not being properly reset once
> the barrier is released.
> 
> This also makes the notify function a blocking call that forces the task into
> a wait state when not all task's have returned from waiting from the previous
> barrier release.
> 
> A non-blocking notify routine is also provided.
> 
> Signed-off-by: Yuji Mano <yuji.mano at am.sony.com>

Acked-by: Kazunori Asayama <asayama at sm.sony.co.jp>

> 
> ---
> v2:
>  - fixed functionality of the barrier with the requirement that
>    (total count == # of notify == # of wait calls)
>  - reset barrier when all tasks have notified and waited
>  - return error when # of notifies exceeds barrier total
> v3:
>  - change notify routine to block when not all tasks have completed waiting for
>    previous barrier
>  - add non-blocking routine (mars_task_barrier_try_notify)
>  - update patch header
> 
>  include/common/mars/mars_task_barrier_types.h |    7 +
>  include/mpu/mars/mars_task_barrier.h          |   18 +++-
>  src/host/lib/mars_task_barrier.c              |    6 -
>  src/mpu/lib/mars_task_barrier.c               |  112 ++++++++++++++++++++++----
>  4 files changed, 123 insertions(+), 20 deletions(-)
> 

-- 
(ASAYAMA Kazunori
  (asayama at sm.sony.co.jp))
t



More information about the cbe-oss-dev mailing list