[Cbe-oss-dev] [patch 2/4 v2] MARS: Build file cleanup

[Yuji Mano]

Geoff Levand wrote:
> Cleanup build files:
>  o Use the git revision in default package version.
>  o Add configure option --with-mars-platform to support platform
>    specific builds.
>  o Move embedspu from mpu makefile to host makefile.
>  o Add makefile variable MARS_KERNEL.
>  o Change default prefix from /usr to /usr/local.
>  o Remove 'host_alias=spu' hack with top level configure logic.
>  o Remove unneeded Makefile.am files.
>  o Remove unneeded files config.sub.patch, VERSION.
>  o Update README file.
> 
> Signed-off-by: Geoff Levand <geoffrey.levand at am.sony.com>
> ---
> 
> V2:
>  o Removed --with-mars-kernel configure option.
>  o Combined --with-mars-host and --with-mars-mpu configure options into
>    --with-mars-platform.
>  o Removed makefile tabs replacement.
>  o Changed include_HEADERS to pkginclude_HEADERS.
> 
>  Makefile.am                  |   11 ----
>  README                       |   73 ++++++-------------------------
>  VERSION                      |    2 
>  bootstrap                    |   61 +++++++++++++++++---------
>  config.sub.patch             |   24 ----------
>  configure.ac.in              |   96 +++++++++++++++++++++++++++++++++--------
>  include/Makefile.am          |   90 --------------------------------------
>  src/Makefile.am              |   41 -----------------
>  src/host/Makefile.am         |   46 -------------------
>  src/host/bootstrap           |   53 ----------------------
>  src/host/config.sub.patch    |   24 ----------
>  src/host/configure.ac.in     |   55 -----------------------
>  src/host/lib/Makefile.am     |  100 ++++++++++++++++++++++++++++++++++---------
>  src/host/lib/bootstrap       |   48 ++++++++++++++++++++
>  src/host/lib/configure.ac.in |   74 +++++++++++++++++++++++++++++++
>  src/mpu/Makefile.am          |    5 --
>  src/mpu/bootstrap            |    7 ---
>  src/mpu/config.sub.patch     |   24 ----------
>  src/mpu/configure.ac.in      |   44 +++++++++++-------
>  src/mpu/kernel/Makefile.am   |   53 ++++++++++++++++++----
>  src/mpu/lib/Makefile.am      |   45 ++++++++++++++++++-
>  21 files changed, 449 insertions(+), 527 deletions(-)

I prefer keeping bootstrap/configure.ac.in in the src/host directory as it was
previously. Not only does that keep the build directory structure symmetrical
to the mpu side, but also it doesn't clutter the src/host/lib directory with
all the autotools generated files and makes it easier to look at just the sources.

Otherwise the patch looks good.

Regards,
Yuji