[Cbe-oss-dev] [patch 3/4 v2] MARS: Fix build warnings

Kazunori Asayama asayama at sm.sony.co.jp
Mon Sep 1 14:57:18 EST 2008


Geoff Levand wrote:
> Fix various build warnings.
> 
> Fix these build warnings:
> mars.c: In function 'create_mpu_contexts':
> mars.c:88: warning: comparison between signed and unsigned
> mars.c: In function 'mars_initialize':
> mars.c:137: warning: comparison between signed and unsigned
> mars_task.c: In function 'mars_task_initialize':
> mars_task.c:97: warning: cast to pointer from integer of different size
> mars_task.c: In function 'mars_task_finalize':
> mars_task.c:118: warning: cast to pointer from integer of different size
> mars_task.c:130: warning: cast to pointer from integer of different size
> mars_task.c: In function 'mars_task_schedule':
> mars_task.c:148: warning: cast to pointer from integer of different size
> mars_task.c: In function 'mars_task_wait':
> mars_task.c:182: warning: cast to pointer from integer of different size
> mars_task.c: In function 'mars_task_try_wait':
> mars_task.c:197: warning: cast to pointer from integer of different size
> mars_task_barrier.c: In function 'mars_task_barrier_initialize':
> mars_task_barrier.c:53: warning: unused variable 'i'
> mars_task_event_flag.c: In function 'mars_task_event_flag_set':
> mars_task_event_flag.c:108: warning: cast to pointer from integer of different size
> mars_task_event_flag.c:144: warning: implicit declaration of function 'memmove'
> mars_task_event_flag.c:144: warning: incompatible implicit declaration of built-in function 'memmove'
> mars_task_queue.c: In function 'mars_task_queue_clear':
> mars_task_queue.c:113: warning: cast to pointer from integer of different size
> mars_task_queue.c: In function 'push_update':
> mars_task_queue.c:138: warning: cast to pointer from integer of different size
> mars_task_queue.c:158: warning: implicit declaration of function 'memmove'
> mars_task_queue.c:158: warning: incompatible implicit declaration of built-in function 'memmove'
> mars_task_queue.c: In function 'push':
> mars_task_queue.c:188: warning: implicit declaration of function 'memcpy'
> mars_task_queue.c:188: warning: incompatible implicit declaration of built-in function 'memcpy'
> mars_task_queue.c:188: warning: cast to pointer from integer of different size
> mars_task_queue.c: In function 'pop_update':
> mars_task_queue.c:211: warning: cast to pointer from integer of different size
> mars_task_queue.c:231: warning: incompatible implicit declaration of built-in function 'memmove'
> mars_task_queue.c: In function 'pop':
> mars_task_queue.c:261: warning: incompatible implicit declaration of built-in function 'memcpy'
> mars_task_queue.c:261: warning: cast to pointer from integer of different size
> mars_task_signal.c: In function 'mars_task_signal_send':
> mars_task_signal.c:49: warning: cast to pointer from integer of different size
> mars_task_signal.c:51: warning: implicit declaration of function 'workload_queue_signal_send'
> 
> Signed-off-by: Geoff Levand <geoffrey.levand at am.sony.com>
> ---
> 
> V2:
>  o Rebase to series.
> 
>  src/host/lib/mars.c                 |    4 ++--
>  src/host/lib/mars_task.c            |   12 ++++++------
>  src/host/lib/mars_task_barrier.c    |    2 --
>  src/host/lib/mars_task_event_flag.c |    3 ++-
>  src/host/lib/mars_task_queue.c      |   12 ++++++------
>  src/host/lib/mars_task_signal.c     |    3 ++-
>  6 files changed, 18 insertions(+), 18 deletions(-)

Many of this patch and the next one (4/4) seem to conflict with the
current Mano-san's works, and some base code of your patches are going
to be obsolete by his changes. I think it's better that Mano-san takes
these your efforts over and reworks on them later. What do you think?

-- 
(ASAYAMA Kazunori
  (asayama at sm.sony.co.jp))
t



More information about the cbe-oss-dev mailing list