[Cbe-oss-dev] [PATCH 1/4] powerpc/spufs: sputrace: only enable logging on open(), prevent multiple openers

Christoph Hellwig hch at lst.de
Sun Oct 19 00:23:25 EST 2008


On Thu, Oct 16, 2008 at 11:00:55AM +1100, Jeremy Kerr wrote:
> Currently, sputrace will start logging to the event buffer before the
> log buffer has been open()ed. This results in a heap of "lost samples"
> warnings if the sputrace file hasn't yet been opened.
> 
> Since the buffer is reset on open() anyway, there's no need to enable
> logging when no-one has opened the log.

Did you talk to the PDT people about this?  When we only start the
logging in open we'll always lose some samples between application
startup and PDT opening the file.




More information about the cbe-oss-dev mailing list