[Cbe-oss-dev] [PATCH] libspe2: use SPU_CREATE_NOSHED also for emulated isolation mode

[Kazunori Asayama]

D. Herrendoerfer wrote:
> This patch modifies the way that emulated isolated mode binaries are
> handled by the scheduler. By starting them with SPU_CREATE_NOSCHED the
> behaviour is closer to that of true isolated mode binaries.
> 
> Signed-off-by: D. Herrendoerfer <d.herrendoerfer at de.ibm.com>
> 
> OK to apply ?

One major reason why we want to use SPE_ISOLATE_EMULATE is because
that makes it possible to debug isolated mode programs. I'm not sure
that your change has no unexpected side effect regarding debugging
facility. No problem?

An alternative solution is to provide separate 'SPE_NOSCHED' flag,
so that users can choose behavior of SPE_ISOLATE_EMULATE.

> 
> Index: libspe2/spebase/create.c
> ===================================================================
> --- libspe2/spebase/create.c    (revision 121)
> +++ libspe2/spebase/create.c    (working copy)
> @@ -236,6 +236,10 @@ spe_context_ptr_t _base_spe_context_crea
>                 spu_createflags |= SPU_CREATE_ISOLATE |
> SPU_CREATE_NOSCHED;
>         }
>  
> +       if (flags & SPE_ISOLATE_EMULATE) {
> +               spu_createflags |= SPU_CREATE_NOSCHED;
> +       }
> +
>         if (flags & SPE_EVENTS_ENABLE)
>                 spu_createflags |= SPU_CREATE_EVENTS_ENABLED;
> 
-- 
(ASAYAMA Kazunori
  (asayama at sm.sony.co.jp))
t