[Cbe-oss-dev] [PATCH] spufs: spu_create should send inotify IM_CREATE event

[Jeremy Kerr]

Hi Christoph,

A couple of things:

Can we do the d_delete() in spufs_rmdir()? I think this might better 
encapsulate the 'rmdir' aspect of the function.

We definitely need to unhash the dentry in this path, but I see that 
d_delete won't do this if the dentry's count is one (so leaving the 
final unhash to the next dput()). Since we don't have the 
d_ops->d_delete function pointer set, can we have a situation where the 
dentry is never unhashed?

Maybe it'd be a better idea to set d_ops->d_delete = d_delete, then just 
do the dput()?

(however, I'm still trying to get my head around the vfs dentry 
destruction path, so I could be wrong here :D )

Cheers,


Jeremy