[Cbe-oss-dev] [RFC] [PATCH 4:8] SPU Gang Scheduling - Add gang structure for standalone ctxts

[Luke Browning]

On Tue, 2008-03-11 at 21:56 +0100, Christoph Hellwig wrote:
> On Mon, Mar 03, 2008 at 04:49:35PM -0300, Luke Browning wrote:
> > +	if (!gang) {
> > +		gang = alloc_spu_gang();
> > +		if (!gang)
> > +			goto out_free;
> > +	}
> 
> So we get an anonymous gang here that's not associated with a spufs
> directory.  I think I'd slightly prefer to move this up to the caller
> instead of having it in alloc_spu_context as that would make the logic
> clearer.  Also a little comment about these helper gangs would be
> useful.

By caller, do you mean libspe?  That doesn't work.

> 
> As Arnd said the check for the number of contexts is probably better
> moved to a different patch.

Ok, I will start on a new versions of these patches soon.  It would be
nice to get a few more comments though.  

> 
> But in general this is a nice generalization, we should probably move
> put this in now already.

Luke