[Cbe-oss-dev] Refactored cell powerpc oprofile patch

Denis Joseph Barrow denis.barrow at sonycom.com
Wed Mar 5 23:43:00 EST 2008


Hi Guys,
I've agreed with Geert that we should use __module_put & module_get
to increase & decrease module refcount of the ps3-lpm.ko  or other modules
if oprofile code is using it.

Another minor problem is that ps3-lpm.ko uses the pmu_ops variable.
This means with ps3-lpm.ko is insmodd'ed oprofile gets loaded first
this variable must be moved into the kernel otherwise we have a chicken/egg
situation.

I believe Geoff Levand wants pmu.c unmodified & left in platform/cell/pmu.c
this means I cannot put the cell specific op_model_cell.c stuff
in there as this depends spu call stuff in the oprofile/cell module.
I think if we come up with a clean way of doing this most of the objections
to my changes will be resolved.

I think the pmu.c place would be the best place to put the pmu_ops 
global then.

-- 
Denis Barrow
Software Engineer

Sony Network and Software Technology Centre Europe
The Corporate Village
Da Vincilaan 7-D1
B-1935 Zaventem 
Belgium
 
Phone:	+32 (0)2 700 8611	
Fax:	+32 (0)2 700 8622	
E-mail:	denis.barrow at sonycom.com
Internet:	www.sony-europe.com	




More information about the cbe-oss-dev mailing list