[Cbe-oss-dev] [PATCH 2/2] [POWERPC] spufs: fix invalid scheduling of forgotten contexts

[Christoph Hellwig]

On Thu, Feb 28, 2008 at 10:51:26AM +1100, Jeremy Kerr wrote:
> --- a/arch/powerpc/platforms/cell/spufs/context.c
> +++ b/arch/powerpc/platforms/cell/spufs/context.c
> @@ -109,13 +109,12 @@ void spu_forget(struct spu_context *ctx)
>  
>  	/*
>  	 * This is basically an open-coded spu_acquire_saved, except that
> -	 * we don't acquire the state mutex interruptible.
> +	 * we don't acquire the state mutex interruptible, and we don't
> +	 * want this context to be rescheduled on release.

I think this is fine.  As outlined later in the thread spu_forget
is a special case and we need to do this kind of special casing in here.