[Cbe-oss-dev] [PATCH] ps3disk: Remove a superfluous cast

Christoph Hellwig hch at lst.de
Mon Mar 3 15:19:16 EST 2008


On Fri, Feb 15, 2008 at 02:42:03PM +0100, Geert Uytterhoeven wrote:
> ps3disk: Remove a superfluous cast
> 
> As ps3disk is a ppc64-only driver, sector_t equals to unsigned long, and the
> cast is not needed.
> 
> Reuse in another (possibly 32-bit) driver is protected by the safety net called
> `compiler warning' (with the cast, it may silently truncate to 32-bit).
> If sector_t ever changes, we will get a compiler warning as well (with the
> cast, we won't).

Yes, this sounds fine to me.

ACK.




More information about the cbe-oss-dev mailing list