[Cbe-oss-dev] [PATCH 2:9] spufs: Fix spu status read in spu_stopped()

Luke Browning lukebr at linux.vnet.ibm.com
Fri Jun 6 01:03:32 EST 2008


On Thu, 2008-06-05 at 14:10 +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2008-05-29 at 17:46 -0300, Luke Browning wrote:
> > Fix spu status read in spu_stopped()
> > 
> > If the spu is stopping, re-read the register to get the stopped value.
> > SPU status is a loop control variable in the calling routine.
> > 
> > Changed loop style based on Christoph Hellwig's comment.  
> > 
> > Added eieio() per CBEA specification of spu status register read.
> 
> ???
> 
> Doesn't make sense. Besides, the necessary barrier should already be
> included by the low level MMIO accessor.
> 

Please see my other comment.   It is not included on read operations.

Luke




More information about the cbe-oss-dev mailing list