[Cbe-oss-dev] [PATCH 2:9] spufs: Fix spu status read in spu_stopped()

[Jeremy Kerr]

Hi Luke,

> +	/* Ensure that all spu status bits have been updated */
> +	eieio();
> +
> +top:
> +	*stat = ctx->ops->status_read(ctx);

should the eieio() be repeated for each status read? (ie, have the top: 
label before the eieio)

> +	if (*stat & stopped) {
> +		/*
> +		 * If the spu hasn't finished stopping, we need to
> +		 * re-read the register to get the stopped value.
> +		 */
> +		if (*stat & SPU_STATUS_RUNNING)
> +			goto top;

	cpu_relax() ?

Cheers,


Jeremy