[Cbe-oss-dev] [patch 05/11] powerpc/cell: add spu aware cpufreq governor

[Stephen Rothwell]

Just a couple of trivial things.

On Fri, 04 Jul 2008 21:05:40 +0200 arnd at arndb.de wrote:
>
> + * (C) Copyright IBM Corporation 2006-2008
      ^^^
You should use ©.

> +#define POLL_TIME	100000		/* in us */
                                              ^
How about μ ?

> +struct spu_gov_info_struct {
> +	unsigned long busy_spus;	/* fixed-point */
> +	struct cpufreq_policy *policy;
> +	struct delayed_work work;
> +	unsigned int poll_int;		/* us */

And again.

> +static int calc_freq(struct spu_gov_info_struct *info)
> +{
> +	int cpu;
> +	int busy_spus;
> +
> +	cpu = info->policy->cpu;
> +	busy_spus = atomic_read(&cbe_spu_info[cpu_to_node(cpu)].busy_spus);
> +
> +	CALC_LOAD(info->busy_spus, EXP, busy_spus * FIXED_1);
> +	pr_debug(KERN_ERR "cpu %d: busy_spus=%d, info->busy_spus=%d\n", cpu, busy_spus, info->busy_spus);

Split this line.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/cbe-oss-dev/attachments/20080707/29794dc5/attachment.pgp>