[Cbe-oss-dev] Gang scheduling [RFC] [PATCH 2:9] all ctxts in gang

[André Detsch]

Luke Browning wrote:
> +	/* Can't mix sched and no-sched within the same gang. */
> +	gang = SPUFS_I(dir)->i_gang;
> +	if (gang) {
> +		if ((flags & SPU_CREATE_NOSCHED) ^
> +		    (gang->flags & SPU_CREATE_NOSCHED)) {
> +			ret = -EPERM;
> +			goto out_iput;
> +		}
> +	}
> +

A quick fix here:
There is no "gang->flags". So, while forward-porting the patches, I've 
changed the code to the following:

/* Can't mix sched and no-sched within the same gang. */
gang = SPUFS_I(dir)->i_gang;
if (gang) {
	gang_ctx = list_first_entry(&gang->list, struct spu_context,
				     			gang_list);
	if ((flags & SPU_CREATE_NOSCHED) ^
	    (gang_ctx->flags & SPU_CREATE_NOSCHED)) {
		ret = -EPERM;
		goto out_iput;
	}
}

-- 
André Detsch
Kernel Software Engineer - Linux on Cell
Linux Technology Center Brazil